kernel/drivers/media/platform/samsung, branch linux-rolling-stable

media: exynos4-is: fimc-lite: drop unused module alias

2025-11-03T14:58:42Z

The driver does not support anything but OF probing since commit 47d1f33ff43e ("[media] exynos4-is: Drop drvdata handling in fimc-lite for non-dt platforms") so drop the unused platform module alias. Signed-off-by: Johan Hovold Signed-off-by: Hans Verkuil

media: exynos4-is: fimc-is: drop unused module alias

2025-11-03T14:58:42Z

The driver has never supported anything but OF probing so drop the unused platform module alias. Signed-off-by: Johan Hovold Signed-off-by: Hans Verkuil

media: samsung: exynos4-is: fix potential ABBA deadlock on init

2025-11-03T14:58:41Z

v4l2_device_register_subdev_nodes() must called without taking media_dev->graph_mutex to avoid potential AB-BA deadlock on further subdevice driver initialization. Fixes: fa91f1056f17 ("[media] exynos4-is: Add support for asynchronous subdevices registration") Cc: stable@vger.kernel.org Signed-off-by: Marek Szyprowski Acked-by: Sylwester Nawrocki Signed-off-by: Hans Verkuil

media: samsung: exynos4-is: Use %pe format specifier

2025-10-17T09:31:16Z

The %pe format specifier is designed to print error pointers. It prints a symbolic error name (eg. -EINVAL) and it makes the code simpler by omitting PTR_ERR(). This patch fixes this cocci report: ./platform/samsung/exynos4-is/media-dev.c:1337:16-23: WARNING: Consider using %pe to print PTR_ERR() Signed-off-by: Ricardo Ribalda Acked-by: Sakari Ailus Signed-off-by: Hans Verkuil

media: samsung: s5p-jpeg: Drop unneeded v4l2_m2m_get_vq() NULL check

2025-10-17T09:31:15Z

The v4l2_m2m_get_vq() function never returns NULL. In the set format handler, the check may have been intended to catch invalid format types, but that's not needed as the V4L2 core picks the appropriate VIDIOC_S_FMT ioctl handler based on the format type, so the type can't be incorrect. In the get format handler, the return value is not used for any purpose other than the NULL check, which was therefore probably intended to catch invalid format types. That's not needed for the same reason as in the set format handler. Drop the unneeded return value check and, as the function has no side effect, the unneeded function call as well. Signed-off-by: Laurent Pinchart Reviewed-by: Andrzej Pietrasiewicz Signed-off-by: Hans Verkuil

media: samsung: s5p-g2d: Drop unneeded v4l2_m2m_get_vq() NULL check

2025-10-17T09:31:15Z

The v4l2_m2m_get_vq() function never returns NULL. The check was probably intended to catch invalid format types, but that's not needed as the V4L2 core picks the appropriate VIDIOC_G_FMT ioctl handler based on the format type, so the type can't be incorrect. Drop the unneeded return value check and, as the return value is not used for other purposes and the function has no side effect, the function call as well. Signed-off-by: Laurent Pinchart Reviewed-by: Łukasz Stelmach Signed-off-by: Hans Verkuil

media: s5p-mfc: remove an unused/uninitialized variable

2025-08-29T09:04:02Z

The s5p_mfc_cmd_args structure in the v6 driver is never used, not initialized to anything other than zero, but as of clang-21 this causes a warning: drivers/media/platform/samsung/s5p-mfc/s5p_mfc_cmd_v6.c:45:7: error: variable 'h2r_args' is uninitialized when passed as a const pointer argument here [-Werror,-Wuninitialized-const-pointer] 45 | &h2r_args); | ^~~~~~~~ Just remove this for simplicity. Since the function is also called through a callback, this does require adding a trivial wrapper with the correct prototype. Fixes: f96f3cfa0bb8 ("[media] s5p-mfc: Update MFC v4l2 driver to support MFC6.x") Cc: stable@vger.kernel.org Signed-off-by: Arnd Bergmann Signed-off-by: Hans Verkuil

media: v4l2: Rename second ioctl handlers argument to 'void *priv'

2025-08-13T06:34:01Z

The second argument to the ioctl handlers is not a file handle any more. The standard practice is to name it 'void *priv' in drivers. Many drivers still name it 'void *fh', and a few use more exotic names. Replace those more exotic names with 'void *priv' in all media drivers. Signed-off-by: Laurent Pinchart Acked-by: Jai Luthra Signed-off-by: Hans Verkuil

media: s5p-mfc: Access v4l2_fh from file

2025-08-13T06:33:53Z

The v4l2_fh associated with an open file handle is now guaranteed to be available in file->private_data, initialised by v4l2_fh_add(). Access the v4l2_fh, and from there the driver-specific structure, from the file * in all ioctl handlers. Signed-off-by: Jacopo Mondi Signed-off-by: Hans Verkuil

media: s5p-mfc: Store s5p_mfc_ctx in vb2_queue.drv_priv

2025-08-13T06:33:53Z

The driver stores a pointer to a v4l2_fh in the vb2_queue.drv_priv, which it then has to cast to a s5p_mfc_ctx pointer in all vb2 queue operations. Store the pointer to the s5p_mfc_ctx instead to avoid the cast. While at it, use the vb2_get_drv_priv() helper to access the field. Signed-off-by: Laurent Pinchart Signed-off-by: Hans Verkuil