kernel/drivers/md/persistent-data/dm-space-map-common.c, branch linux-6.9.yHosts the 0x221E linux distro kernel.https://universe.0xinfinity.dev/distro/kernel/atom?h=linux-6.9.y2023-02-14T19:23:07Zdm: avoid useless 'else' after 'break' or return'2023-02-14T19:23:07ZHeinz Mauelshagenheinzm@redhat.com2023-02-07T19:35:25Zurn:sha1:1c3fe2fa946342a784a1375a63be6eb5a25acd76
Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>
dm: prefer '"%s...", __func__'2023-02-14T19:23:07ZHeinz Mauelshagenheinzm@redhat.com2023-02-06T22:42:32Zurn:sha1:1c13188669282dac48f1e67d77f07a746a4899d7
Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>
dm: add missing empty lines2023-02-14T19:23:06ZHeinz Mauelshagenheinzm@redhat.com2023-02-01T22:42:29Zurn:sha1:0ef0b4717aa6849d251b23ae1efe93ca93af540b
Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>
dm: address indent/space issues2023-02-14T19:23:06ZHeinz Mauelshagenheinzm@redhat.com2023-01-25T22:31:55Zurn:sha1:255e2646496fcbf836a3dfe1b535692f09f11b45
Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>
dm: change "unsigned" to "unsigned int"2023-02-14T19:23:06ZHeinz Mauelshagenheinzm@redhat.com2023-01-25T20:14:58Zurn:sha1:86a3238c7b9b759cb864f4f768ab2e24687dc0e6
Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>
dm: add missing SPDX-License-Indentifiers2023-02-14T19:23:06ZHeinz Mauelshagenheinzm@redhat.com2023-01-25T20:00:44Zurn:sha1:3bd940030752a33ff665eefdd74a1cdb74a4f9b0
'GPL-2.0-only' is used instead of 'GPL-2.0' because SPDX has
deprecated its use.
Suggested-by: John Wiele <jwiele@redhat.com>
Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>
dm space map common: add bounds check to sm_ll_lookup_bitmap()2022-01-04T18:58:19ZJoe Thornberejt@redhat.com2021-12-10T13:49:53Zurn:sha1:cba23ac158db7f3cd48a923d6861bee2eb7a2978
Corrupted metadata could warrant returning error from sm_ll_lookup_bitmap().
Signed-off-by: Joe Thornber <ejt@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
dm space map disk: cache a small number of index entries2021-06-04T16:07:23ZJoe Thornberejt@redhat.com2021-04-13T12:09:32Zurn:sha1:6b06dd5a972288d011a49d63eb9f6a5003d2e932
The disk space map stores it's index entries in a btree, these are
accessed very frequently, so having a few cached makes a big difference
to performance.
With this change provisioning a new block takes roughly 20% less cpu.
Signed-off-by: Joe Thornber <ejt@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
dm space maps: improve performance with inc/dec on ranges of blocks2021-06-04T16:07:22ZJoe Thornberejt@redhat.com2021-04-13T10:03:45Zurn:sha1:be500ed721a6ec8d49bf0814c277ce7162acee0e
When we break sharing on btree nodes we typically need to increment
the reference counts to every value held in the node. This can
cause a lot of repeated calls to the space maps. Fix this by changing
the interface to the space map inc/dec methods to take ranges of
adjacent blocks to be operated on.
For installations that are using a lot of snapshots this will reduce
cpu overhead of fundamental operations such as provisioning a new block,
or deleting a snapshot, by as much as 10 times.
Signed-off-by: Joe Thornber <ejt@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
dm space map common: fix division bug in sm_ll_find_free_block()2021-04-19T16:48:13ZJoe Thornberejt@redhat.com2021-04-13T08:11:53Zurn:sha1:5208692e80a1f3c8ce2063a22b675dd5589d1d80
This division bug meant the search for free metadata space could skip
the final allocation bitmap's worth of entries. Fix affects DM thinp,
cache and era targets.
Cc: stable@vger.kernel.org
Signed-off-by: Joe Thornber <ejt@redhat.com>
Tested-by: Ming-Hung Tsai <mtsai@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>