kernel/drivers/input/misc/wistron_btns.c, branch linux-6.9.y

Input: wistron_btns - convert to platform remove callback returning void

2023-09-24T02:16:44Z

The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Link: https://lore.kernel.org/r/20230920125829.1478827-27-u.kleine-koenig@pengutronix.de Signed-off-by: Dmitry Torokhov

Input: wistron_btns - use pm_sleep_ptr() to allow removal of ifdef CONFIG_PM guards

2023-01-27T22:49:53Z

As the guards only apply to suspend and resume, #ifdef CONFIG_PM_SLEEP would have been a tighter protection. As pm_sleep_ptr() lets the compiler see the protected ops structure and callbacks but also lets the compiler remove it as unused code if !CONFIG_PM_SLEEP this allows the #ifdef guards to be removed, slightly simplifying the resulting code. -- It seems likely that DEFINE_SIMPLE_DEV_PM_OPS() would work here but I'd prefer not to make that change unless someone can confirm that the extra callbacks registered will have no unwanted side effects in this driver. Signed-off-by: Jonathan Cameron Link: https://lore.kernel.org/r/20230114171620.42891-17-jic23@kernel.org Signed-off-by: Dmitry Torokhov

Input: wistron_btns - switch to using polled mode of input devices

2019-10-30T00:14:15Z

We have added polled mode to the normal input devices with the intent of retiring input_polled_dev. This converts wistron_btns driver to use the polling mode of standard input devices and removes dependency on INPUT_POLLDEV. Link: https://lore.kernel.org/r/20191017204217.106453-11-dmitry.torokhov@gmail.com Signed-off-by: Dmitry Torokhov

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 414

2019-06-05T15:37:14Z

Based on 1 normalized pattern(s): you can redistribute and or modify this program under the terms of the gnu general public license version 2 as published by the free software foundation this program is distributed in the hope that it will be useful but without any warranty without even the implied warranty of merchantability or fitness for a particular purpose see the gnu general public license for more details you should have received a copy of the gnu general public license along with this program if not write to the free software foundation inc 59 temple place suite 330 boston ma 02111 1307 usa extracted by the scancode license scanner the SPDX license identifier GPL-2.0-only has been chosen to replace the boilerplate/reference in 2 file(s). Signed-off-by: Thomas Gleixner Reviewed-by: Armijn Hemel Reviewed-by: Allison Randal Cc: linux-spdx@vger.kernel.org Link: https://lkml.kernel.org/r/20190531190113.054726165@linutronix.de Signed-off-by: Greg Kroah-Hartman

Input: wistron_btns - remove use of sparse_keymap_free

2017-03-09T18:06:12Z

Now that sparse keymap uses managed memory, we no longer need to clean it up manually. Signed-off-by: Dmitry Torokhov

input: misc: drop owner assignment from platform_drivers

2014-10-20T14:20:40Z

A platform_driver does not need to set an owner, it will be populated by the driver core. Signed-off-by: Wolfram Sang

Input: wistron_btns - add FS AMILO Pro 8210 support

2014-01-28T06:34:42Z

This adds Fujitsu-Siemens AMILO Pro 8210 support to wistron_btns driver. Functions are very similar to already supported AMILO Pro 3505, but 8210 has WIFI led. Such functionality is needed to enable WiFi under Linux on 8210 when it cold boots with hardware rfkill enabled, without booting another operating system or running custom utility that calls appropriate BIOS function. Signed-off-by: Jakub Bogusz Signed-off-by: Dmitry Torokhov

Input: wistron_btns - add MODULE_DEVICE_TABLE

2013-08-13T16:52:17Z

This allows the wistron_btns module to be autoloaded on boot, its functionality is required to support the hardware rfkill switches on most of the supported notebooks, in order to unblock the hard blocked rfkill state for wireless and bluetooth devices. Tested on a Medion MD96500: alias: dmi*:svn*MEDIONPC*:pn*WIM2040*: Signed-off-by: Stefan Lippers-Hollmann Signed-off-by: Dmitry Torokhov

Input: wistron_btns - mark the Medion MD96500 keymap as tested

2013-08-13T16:52:16Z

DMI: MEDIONPC WIM 2040/WIM 2040, BIOS R01-A0O 11/04/2005 wistron_btns: BIOS signature found at c00f6b00, entry point 000FDD50 input: Wistron laptop buttons as /devices/platform/wistron-bios/input/input5 Signed-off-by: Stefan Lippers-Hollmann Signed-off-by: Dmitry Torokhov

Input: wistron_btns - drop bogus MODULE_VERSION macro

2013-08-13T16:52:15Z

MODULE_VERSION is pointless for an in-kernel module and git log confirms that it has never been actually maintained as well (bumped a single time, despite quite major feature additions later on, which haven't been reflected in MODULE_VERSION). Signed-off-by: Stefan Lippers-Hollmann Signed-off-by: Dmitry Torokhov