kernel/drivers/gpu/host1x/job.c, branch linux-4.1.y

drm/tegra: Make job submission 64-bit safe

2014-08-04T08:07:36Z

Job submission currently relies on the fact that struct drm_tegra_reloc and struct host1x_reloc are the same size and uses a simple call to the copy_from_user() function to copy them to kernel space. This causes the handle to be stored in the buffer object field, which then needs a cast to a 32 bit integer to resolve it to a proper buffer object pointer and store it back in the buffer object field. On 64-bit architectures that will no longer work, since pointers are 64 bits wide whereas handles will remain 32 bits. This causes the sizes of both structures to because different and copying will no longer work. Fix this by adding a new function, host1x_reloc_get_user(), that copies the structures field by field. While at it, use substructures for the command and target buffers in struct host1x_reloc for better readability. Also use unsized types to make it more obvious that this isn't part of userspace ABI. Signed-off-by: Thierry Reding

gpu: host1x: do not check previously handled gathers

2014-02-12T06:50:37Z

When patching gathers, we don't need to check against gathers with lower indices than the current one, as they are guaranteed to already have been handled. Signed-off-by: Erik Faye-Lund Acked-By: Terje Bergstrom Signed-off-by: Thierry Reding

gpu: host1x: Export public API

2013-12-19T08:29:50Z

Make the public API symbols visible so that depending drivers can be built as a module. Signed-off-by: Thierry Reding

gpu: host1x: Expose syncpt and channel functionality

2013-10-31T08:20:11Z

Expose the buffer objects, syncpoint and channel functionality in the public public header so that drivers can use them. Signed-off-by: Thierry Reding

gpu: host1x: firewall: Refactor register check

2013-10-31T08:20:08Z

The same code sequence is used in various places to validate a register access in the command stream. This can be refactored into a separate function. Signed-off-by: Thierry Reding

gpu: host1x: firewall: Rename cmdbuf_id -> cmdbuf

2013-10-31T08:20:08Z

The value stored in this field is a pointer to a command buffer, not an ID. Avoid some confusion by reflecting that in the field's name. Signed-off-by: Thierry Reding

gpu: host1x: Fix alignment of function arguments

2013-10-31T08:20:08Z

Arguments on subsequent lines should be aligned with the first argument. This one occurrence went unnoticed during code review. Signed-off-by: Thierry Reding

gpu: host1x: check relocs after all gathers are consumed

2013-10-31T08:20:04Z

The num_relocs count are passed to the kernel per job, not per gather. For multi-gather jobs, we would previously fail if there were relocs in other gathers aside from the first one. Fix this by simply moving the check until all gathers have been consumed. Signed-off-by: Erik Faye-Lund Reviewed-by: Arto Merilainen Acked-By: Terje Bergstrom Signed-off-by: Thierry Reding

gpu: host1x: returning success instead of -ENOMEM

2013-08-27T08:20:12Z

There is a mistake here so it returns PTR_ERR(NULL) which is success instead of -ENOMEM. Signed-off-by: Dan Carpenter Signed-off-by: Thierry Reding

gpu: host1x: fix an integer overflow check

2013-08-27T08:20:11Z

Tegra is a 32 bit arch. On 32 bit systems then size_t is 32 bits so "total" will never be higher than UINT_MAX because of integer overflows. We need cast to u64 first before doing the math. Also the addition earlier: unsigned int num_unpins = num_cmdbufs + num_relocs; That can overflow as well, but I think it's still safe because we check both "num_cmdbufs" and "num_relocs" again in this test. Signed-off-by: Dan Carpenter Signed-off-by: Thierry Reding