kernel/drivers/gpu/drm/nouveau/nvkm/subdev/timer/base.c, branch linux-4.17.y

drm/nouveau/tmr: remove nvkm_timer_alarm_cancel()

2017-06-16T04:04:42Z

nvkm_timer_alarm() already handles this as part of protecting against callers passing in no timeout value. Signed-off-by: Ben Skeggs

drm/nouveau/tmr: fully separate alarm execution/pending lists

2017-06-06T04:04:07Z

Reusing the list_head for both is a bad idea. Callback execution is done with the lock dropped so that alarms can be rescheduled from the callback, which means that with some unfortunate timing, lists can get corrupted. The execution list should not require its own locking, the single function that uses it can only be called from a single context. Signed-off-by: Ben Skeggs Cc: stable@vger.kernel.org

drm/nouveau/tmr: avoid processing completed alarms when adding a new one

2017-05-11T22:32:58Z

The idea here was to avoid having to "manually" program the HW if there's a new earliest alarm. This was lazy and bad, as it leads to loads of fun races between inter-related callers (ie. therm). Turns out, it's not so difficult after all. Go figure ;) Signed-off-by: Ben Skeggs Cc: stable@vger.kernel.org

drm/nouveau/tmr: fix corruption of the pending list when rescheduling an alarm

2017-05-11T22:32:57Z

At least therm/fantog "attempts" to work around this issue, which could lead to corruption of the pending alarm list. Fix it properly by not updating the timestamp without the lock held, or trying to add an already pending alarm to the pending alarm list.... Signed-off-by: Ben Skeggs Cc: stable@vger.kernel.org

drm/nouveau/tmr: handle races with hw when updating the next alarm time

2017-05-11T22:32:57Z

If the time to the next alarm is short enough, we could race with HW and end up with an ~4 second delay until it triggers. Fix this by checking again after we update HW. Signed-off-by: Ben Skeggs Cc: stable@vger.kernel.org

drm/nouveau/core: remove pmc_enable argument from subdev ctor

2016-05-20T04:43:04Z

These are now specified directly in the MC subdev. Signed-off-by: Ben Skeggs

drm/nouveau/tmr: convert to new-style nvkm_subdev

2015-08-28T02:40:45Z

Signed-off-by: Ben Skeggs

drm/nouveau/tmr: type-safe PTIMER-based delay/wait macros

2015-08-28T02:40:19Z

These require an explicit struct nvkm_device pointer, unlike the previous macros which take a void *, and work for (almost) anything derived from nvkm_object by using some heuristics. These macros are more general than the previous ones, and can be used to handle PTIMER-based busy-waits (will be used in later devinit fixes) as well as more complicated wait conditions. Signed-off-by: Ben Skeggs

drm/nouveau/tmr: switch to device pri macros

2015-08-28T02:40:16Z

Signed-off-by: Ben Skeggs

drm/nouveau/tmr: cosmetic changes

2015-08-28T02:40:09Z

This is purely preparation for upcoming commits, there should be no code changes here. Signed-off-by: Ben Skeggs