kernel/drivers/gpu/drm/msm/edp/edp_ctrl.c, branch linux-4.17.y

drm/msm/edp: convert to msm_clk_get()

2017-10-28T15:01:33Z

We already have, as a result of upstreaming the gpu bindings, msm_clk_get() which will try to get the clock both without and with a "_clk" suffix. Use this in eDP code so we can drop the "_clk" suffix in bindings while maintaing backwards compatibility. Signed-off-by: Rob Clark Reviewed-by: Sean Paul

drm/msm: fix include notation and remove -Iinclude/drm flag

2017-05-17T12:35:54Z

Include instead of relative path from include/drm, then remove the -Iinclude/drm compiler flag. While we are here, sort the touched parts with public headers first. mdp4_kms.h must declare struct device_node to be self-contained. Signed-off-by: Masahiro Yamada Signed-off-by: Daniel Vetter Link: http://patchwork.freedesktop.org/patch/msgid/1493009447-31524-11-git-send-email-yamada.masahiro@socionext.com

drm/msm/edp: Drop regulator_set_voltage call

2016-05-08T14:22:17Z

The eDP driver tries to set a fixed voltage for one of its regulators(vdda) before enabling it. This shouldn't be done by the driver, the voltage constraints should be specified on the regulator via DT and managed by the regulator core. A driver should call regulator_set_voltage only if it needs to change the voltage during runtime. Drop the regulator_set_voltage call. Mention in a comment the voltage that the regulator expects. Signed-off-by: Archit Taneja Signed-off-by: Rob Clark

drm/msm: Move call to PTR_ERR_OR_ZERO after reassignment

2016-05-08T14:22:16Z

Here, a location is reset to NULL before being passed to PTR_ERR. So, PTR_ERR should be called before its argument is reassigned to NULL. Further to simplify things use PTR_ERR_OR_ZERO instead of PTR_ERR and IS_ERR. Problem found using Coccinelle. Signed-off-by: Vaishali Thakkar Reviewed-by: Eric Engestrom [fixed fmt string warning (s/%ld/%d/)] Signed-off-by: Rob Clark

drm/msm/dp: use flags argument of devm_gpiod_get to set direction

2015-07-06T08:10:21Z

Since 39b2bbe3d715 (gpio: add flags argument to gpiod_get*() functions) which appeared in v3.17-rc1, the gpiod_get* functions take an additional parameter that allows to specify direction and initial value for output. Use this to simplify the driver. Furthermore this is one caller less that stops us making the flags argument to gpiod_get*() mandatory. Acked-by: Alexandre Courbot Acked-by: Linus Walleij Signed-off-by: Uwe Kleine-König

drm/msm: drop redundant debug output

2015-06-11T17:11:03Z

wait_for_completion_timeout returns 0 in case of timeout and never return < 0 so there is no additional information in printing the value of time_left here as it will always be 0, thus it can be dropped. Signed-off-by: Nicholas Mc Guire Signed-off-by: Rob Clark

drm/msm: wait_for_completion_timeout return is never negative

2015-06-11T17:11:03Z

wait_for_completion_timeout returns >= 0 but never negative - so the error check should be against equality to 0 not <= 0. Signed-off-by: Nicholas Mc Guire Signed-off-by: Rob Clark

drm/msm: match wait_for_completion_timeout return type

2015-06-11T17:11:03Z

return type of wait_for_completion_timeout is unsigned long not int, this patch assigns the return value of wait_for_completion_timeout to an appropriately typed and named variable. Signed-off-by: Nicholas Mc Guire Signed-off-by: Rob Clark

drm/msm/dp: fix error return code

2015-05-14T15:28:41Z

Return a negative error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier ret; expression e1,e2; @@ ( if (\(ret < 0\|ret != 0\)) { ... return ret; } | ret = 0 ) ... when != ret = e1 when != &ret *if(...) { ... when != ret = e2 when forall return ret; } // Signed-off-by: Julia Lawall

regulator: fixes for regulator_set_optimum_mode name change

2015-03-10T10:39:32Z

Signed-off-by: Stephen Rothwell Signed-off-by: Mark Brown