kernel/drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c, branch linux-4.17.y

drm/amdkfd: Hardware DWORD size is 4 bytes

2017-11-06T19:52:27Z

Don't use sizeof(uint32_t) or similar types for hardware or firmware DWORD size. The hardware and firmware don't care about Linux types. Signed-off-by: Felix Kuehling Reviewed-by: Alex Deucher Signed-off-by: Oded Gabbay

drm/amdkfd: Compress unnecessary function parameters

2017-09-27T04:09:53Z

Signed-off-by: Yong Zhao Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay

drm/amdkfd: Use VMID bitmap from KGD v2

2017-09-20T22:10:18Z

The hard-coded values related to VMID were removed in KFD, as those values can be calculated in the KFD initialization function. v2: remove unnecessary local variable Signed-off-by: Yong Zhao Signed-off-by: Felix Kuehling Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay

drm/amdkfd: Handle remaining BUG_ONs more gracefully v2

2017-08-16T03:00:12Z

In most cases, BUG_ONs can be replaced with WARN_ON with an error return. In some void functions just turn them into a WARN_ON and possibly an early exit. v2: * Cleaned up error handling in pm_send_unmap_queue * Removed redundant WARN_ON in kfd_process_destroy_delayed Signed-off-by: Felix Kuehling Signed-off-by: Oded Gabbay

drm/amdkfd: Remove BUG_ONs for NULL pointer arguments

2017-08-16T03:00:09Z

Remove BUG_ONs that check for NULL pointer arguments that are dereferenced in the same function. Dereferencing the NULL pointer will generate a BUG anyway, so the explicit check is redundant and unnecessary overhead. Signed-off-by: Felix Kuehling Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay

drm/amdkfd: Change x==NULL/false references to !x

2017-08-16T03:00:06Z

Upstream prefers the !x notation to x==NULL or x==false. Along those lines change the ==true or !=NULL references as well. Also make the references to !x the same, excluding () for readability. Signed-off-by: Kent Russell Signed-off-by: Felix Kuehling Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay

drm/amdkfd: Consolidate and clean up log commands

2017-08-16T03:00:05Z

Consolidate log commands so that dev_info(NULL, "Error...") uses the more accurate pr_err, remove the module name from the log (can be seen via dynamic debugging with +m), and the function name (can be seen via dynamic debugging with +f). We also don't need debug messages saying what function we're in. Those can be added by devs when needed Don't print vendor and device ID in error messages. They are typically the same for all GPUs in a multi-GPU system. So this doesn't add any value to the message. Lastly, remove parentheses around %d, %i and 0x%llX. According to kernel.org: "Printing numbers in parentheses (%d) adds no value and should be avoided." Signed-off-by: Kent Russell Signed-off-by: Yong Zhao Signed-off-by: Felix Kuehling Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay

drm/amdkfd: Clean up KFD style errors and warnings v2

2017-08-16T03:00:04Z

Using checkpatch.pl -f showed a number of style issues. This patch addresses as many of them as possible. Some long lines have been left for readability, but attempts to minimize them have been made. v2: Broke long lines in gfx_v7 get_fw_version Signed-off-by: Kent Russell Signed-off-by: Felix Kuehling Signed-off-by: Oded Gabbay

drm/amdkfd: Remove bogus divide-by-sizeof(uint32_t)

2017-08-16T03:00:01Z

kfd2kgd->address_watch_get_offset returns dword register offsets. Signed-off-by: Felix Kuehling Signed-off-by: Oded Gabbay

drm/amdkfd: Fix typo in dbgdev_wave_reset_wavefronts

2017-08-16T02:59:59Z

Signed-off-by: Felix Kuehling Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay