kernel/drivers/firmware/google/vpd.c, branch linux-4.16.y

firmware: vpd: Fix platform driver and device registration/unregistration

2017-11-28T15:57:18Z

The driver exit function needs to unregister both platform device and driver. Also, during registration, register driver first and perform error checks. Fixes: 049a59db34eb ("firmware: Google VPD sysfs driver") Signed-off-by: Guenter Roeck Cc: stable Tested-by: Randy Dunlap Reviewed-by: Dmitry Torokhov Signed-off-by: Greg Kroah-Hartman

firmware: vpd: Tie firmware kobject to device lifetime

2017-11-28T15:57:18Z

It doesn't make sense to have /sys/firmware/vpd if the device is not instantiated, so tie its lifetime to the device. Fixes: 049a59db34eb ("firmware: Google VPD sysfs driver") Signed-off-by: Guenter Roeck Cc: stable Reviewed-by: Dmitry Torokhov Tested-by: Randy Dunlap Signed-off-by: Greg Kroah-Hartman

firmware: vpd: Destroy vpd sections in remove function

2017-11-28T15:57:18Z

vpd sections are initialized during probe and thus should be destroyed in the remove function. Fixes: 049a59db34eb ("firmware: Google VPD sysfs driver") Cc: stable Signed-off-by: Guenter Roeck Reviewed-by: Dmitry Torokhov Tested-by: Randy Dunlap Signed-off-by: Greg Kroah-Hartman

firmware: vpd: use memunmap instead of iounmap

2017-08-28T14:55:47Z

In functions vpd_sections_init() and vpd_section_init(), iounmap() is used to unmap memory. However, in these cases, memunmap() should be used. Signed-off-by: Pan Bian Reviewed-by: Dmitry Torokhov Signed-off-by: Greg Kroah-Hartman

Merge 4.12-rc5 into char-misc-next

2017-06-12T06:18:10Z

We want the char/misc driver fixes in here as well. Signed-off-by: Greg Kroah-Hartman

Revert "firmware: vpd: remove platform driver"

2017-05-27T09:46:26Z

This reverts commit 7975bd4cca05a99aa14964cfa22366ee64da50ad, because VPD relies on driver core to handle deferrals returned by coreboot_table_find(). Signed-off-by: Dmitry Torokhov Reviewed-by: Guenter Roeck Signed-off-by: Greg Kroah-Hartman

firmware: vpd: remove platform driver

2017-05-25T13:41:20Z

There is no reason why VPD should register platform device and driver, given that we do not use their respective kobjects to attach attributes, nor do we need suspend/resume hooks, or any other features of device core. Signed-off-by: Dmitry Torokhov Reviewed-by: Guenter Roeck Signed-off-by: Greg Kroah-Hartman

firmware: vpd: do not clear statically allocated data

2017-05-25T13:41:20Z

ro_vpd and rw_vpd are static module-scope variables that are guaranteed to be initialized with zeroes, there is no need for explicit memset(). Signed-off-by: Dmitry Torokhov Reviewed-by: Guenter Roeck Signed-off-by: Greg Kroah-Hartman

firmware: vpd: use kasprintf() when forming name of 'raw' attribute

2017-05-25T13:41:20Z

When creating name for the "raw" attribute, let's switch to using kaspeintf() instead of doing it by hand. Also make sure we handle errors. Signed-off-by: Dmitry Torokhov Reviewed-by: Guenter Roeck Signed-off-by: Greg Kroah-Hartman

firmware: vpd: use kdtrndup when copying section key

2017-05-25T13:41:20Z

Instead of open-coding kstrndup with kzalloc + memcpy, let's use the helper. Signed-off-by: Dmitry Torokhov Reviewed-by: Guenter Roeck Signed-off-by: Greg Kroah-Hartman