kernel/drivers/crypto/intel/keembay, branch linux-rolling-stable

crypto: keembay - Add missing check after sg_nents_for_len()

2025-10-15T10:03:43Z

[ Upstream commit 4e53be21dd0315c00eaf40cc8f8c0facd4d9a6b2 ] sg_nents_for_len() returns an int which is negative in case of error. Fixes: 472b04444cd3 ("crypto: keembay - Add Keem Bay OCS HCU driver") Signed-off-by: Thomas Fourier Signed-off-by: Herbert Xu Signed-off-by: Sasha Levin

crypto: keembay - Use min() to simplify ocs_create_linked_list_from_sg()

2025-07-27T12:41:45Z

Use min() to simplify ocs_create_linked_list_from_sg() and improve its readability. Signed-off-by: Thorsten Blum Signed-off-by: Herbert Xu

crypto: keembay - Fix dma_unmap_sg() nents value

2025-07-18T10:51:59Z

The dma_unmap_sg() functions should be called with the same nents as the dma_map_sg(), not the value the map function returned. Fixes: 472b04444cd3 ("crypto: keembay - Add Keem Bay OCS HCU driver") Signed-off-by: Thomas Fourier Signed-off-by: Herbert Xu

crypto: drivers - Switch back to struct platform_driver::remove()

2024-10-19T00:44:30Z

After commit 0edb555a65d1 ("platform: Make platform_driver::remove() return void") .remove() is (again) the right callback to implement for platform drivers. Convert all platform drivers below drivers/crypto to use .remove(), with the eventual goal to drop struct platform_driver::remove_new(). As .remove() and .remove_new() have the same prototypes, conversion is done by just changing the structure member name in the driver initializer. Signed-off-by: Uwe Kleine-König Signed-off-by: Herbert Xu

crypto: keembay - fix module autoloading

2024-08-24T13:36:07Z

Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded based on the alias from of_device_id table. Signed-off-by: Liao Chen Acked-by: Daniele Alessandrelli Signed-off-by: Herbert Xu

crypto: keembay - add missing MODULE_DESCRIPTION() macro

2024-06-07T11:47:58Z

make allmodconfig && make W=1 C=1 reports: WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/crypto/intel/keembay/keembay-ocs-hcu.o Add the missing invocation of the MODULE_DESCRIPTION() macro. Signed-off-by: Jeff Johnson Signed-off-by: Jeff Johnson Signed-off-by: Herbert Xu

crypto: intel/keembay-ocs-hcu - Convert to platform remove callback returning void

2023-10-27T10:04:26Z

The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Signed-off-by: Herbert Xu

crypto: intel/keembay-ocs-ecc - Convert to platform remove callback returning void

2023-10-27T10:04:26Z

crypto: intel/keembay-ocs-aes - Convert to platform remove callback returning void

2023-10-27T10:04:26Z

crypto: keembay - Don't pass errors to the caller in .remove()

2023-10-01T08:28:15Z

Returning an error code in the remove function of a platform device has no effect (compared to returning zero) apart from an error message, that the error is ignored. Then the device is removed irrespective of the returned value. As kmb_ocs_hcu_remove is only called after kmb_ocs_hcu_probe() returned successfully, platform_get_drvdata() never returns NULL and so the respective check can just be dropped. crypto_engine_exit() might return an error code but already emits an error message in that case, so better return zero in kmb_ocs_hcu_remove() even in this case to suppress another error message. All other crypto drivers also ignore the return value of crypto_engine_exit(). Signed-off-by: Uwe Kleine-König Signed-off-by: Herbert Xu