kernel/drivers/char/virtio_console.c, branch linux-4.3.y

virtio_console: silence a static checker warning

2015-05-24T19:24:35Z

My static checker complains that this sprintf() can overflow but really it can't. Just silence the warning by using snprintf(). Signed-off-by: Dan Carpenter Reviewed-by: Amit Shah Signed-off-by: Greg Kroah-Hartman

virtio_console: Use bool function return values of true/false not 1/0

2015-04-03T14:15:30Z

Use the normal return values for bool functions Signed-off-by: Joe Perches Reviewed-by: Amit Shah Signed-off-by: Greg Kroah-Hartman

virtio_console: avoid config access from irq

2015-03-05T03:06:18Z

when multiport is off, virtio console invokes config access from irq context, config access is blocking on s390. Fix this up by scheduling work from config irq - similar to what we do for multiport configs. Signed-off-by: Michael S. Tsirkin Reviewed-by: Amit Shah Signed-off-by: Rusty Russell Cc: stable@kernel.org

virtio_console: init work unconditionally

2015-03-05T03:06:17Z

when multiport is off, we don't initialize config work, but we then cancel uninitialized control_work on freeze. Signed-off-by: Michael S. Tsirkin Reviewed-by: Amit Shah Signed-off-by: Rusty Russell Cc: stable@kernel.org

virtio: don't require a config space on the console device.

2015-02-11T04:33:17Z

Strictly, it's only needed when we have features (size or multiport). Signed-off-by: Rusty Russell

virtio/console: verify device has config space

2015-01-21T05:58:46Z

Some devices might not implement config space access (e.g. remoteproc used not to - before 3.9). virtio/console needs config space access so make it fail gracefully if not there. Signed-off-by: Michael S. Tsirkin Signed-off-by: Rusty Russell

virtio_console: fix sparse warnings

2014-12-09T10:06:33Z

CHECK drivers/char/virtio_console.c drivers/char/virtio_console.c:687:36: warning: incorrect type in argument 1 (different address spaces) drivers/char/virtio_console.c:687:36: expected void [noderef] *to drivers/char/virtio_console.c:687:36: got char *out_buf drivers/char/virtio_console.c:790:35: warning: incorrect type in argument 2 (different address spaces) drivers/char/virtio_console.c:790:35: expected char *out_buf drivers/char/virtio_console.c:790:35: got char [noderef] *ubuf fill_readbuf is reused with both kernel and userspace pointers, depending on value of to_user flag. Tag address parameter as __user, and cast to/from regular pointer type when we know it's safe. Signed-off-by: Michael S. Tsirkin

virtio: drop VIRTIO_F_VERSION_1 from drivers

2014-12-09T10:06:32Z

Core activates this bit automatically now, drop it from drivers that set it explicitly. Signed-off-by: Michael S. Tsirkin

virtio_console: virtio 1.0 support

2014-12-09T10:06:32Z

Pretty straight-forward, just use accessors for all fields. Signed-off-by: Michael S. Tsirkin

virtio: use u32, not bitmap for features

2014-12-09T10:05:23Z

It seemed like a good idea to use bitmap for features in struct virtio_device, but it's actually a pain, and seems to become even more painful when we get more than 32 feature bits. Just change it to a u32 for now. Based on patch by Rusty. Suggested-by: David Hildenbrand Signed-off-by: Rusty Russell Signed-off-by: Cornelia Huck Signed-off-by: Michael S. Tsirkin Reviewed-by: Cornelia Huck