kernel/drivers/base/power/opp.c, branch linux-4.1.y

PM / OPP / clk: Remove unnecessary OOM message

2015-02-12T01:00:52Z

This patch reduces the kernel size by removing error messages that duplicate the normal OOM message. A simplified version of the semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr) @@ identifier f,print,l; expression e; constant char[] c; @@ e = \(kzalloc\|kmalloc\|devm_kzalloc\|devm_kmalloc\)(...); if (e == NULL) { <+... - print(...,c,...); ... when any ( goto l; | return ...; ) ...+> } Signed-off-by: Quentin Lambert Acked-by: Nishanth Menon Signed-off-by: Rafael J. Wysocki

PM / OPP: Assert RCU lock in exported functions

2015-01-23T21:32:38Z

Add lockdep asserts for holding the RCU lock when calling dev_pm_opp_get_freq() and dev_pm_opp_get_voltage() to aid in detecting RCU misuses. These are called often after dev_pm_opp_find_freq_ceil/exact() which already asserts for RCU lock. However one could make an error by releasing lock too early - just after dev_pm_opp_find_freq_ceil(). Signed-off-by: Krzysztof Kozlowski Signed-off-by: Rafael J. Wysocki

PM / OPP: Update kernel documentation

2015-01-23T21:28:25Z

kernel doc has gotten bit-rotted over time. Re-sync with Locking and Return information. document all functions properly and ensure that ./scripts/kernel-doc -v ./drivers/base/power/opp.c >/dev/null returns no errors Signed-off-by: Nishanth Menon Signed-off-by: Rafael J. Wysocki

PM / OPP: Ensure consistent naming of static functions

2015-01-23T21:28:24Z

All exported functions use dev_pm_* prefix and all static functions are now standardized with _ prefix. This is better than having to deal with multiple function naming styles within the same file. Signed-off-by: Nishanth Menon Signed-off-by: Rafael J. Wysocki

PM / OPP: export dev_pm_opp_get_notifier

2015-01-23T21:28:24Z

Allows user drivers such as devfreq to be modules. Signed-off-by: Nishanth Menon Signed-off-by: Rafael J. Wysocki

PM / OPP: take RCU lock in dev_pm_opp_get_opp_count

2014-12-18T00:42:49Z

A lot of callers are missing the fact that dev_pm_opp_get_opp_count needs to be called under RCU lock. Given that RCU locks can safely be nested, instead of providing *_locked() API, let's take RCU lock inside dev_pm_opp_get_opp_count() and leave callers as is. Signed-off-by: Dmitry Torokhov Acked-by: Viresh Kumar Signed-off-by: Rafael J. Wysocki

PM / OPP: fix warning in of_free_opp_table()

2014-12-18T00:42:49Z

Not having OPP defined for a device is not a crime, we should not splat warning in this case. Also, it seems that we are ready to accept invalid dev (find_device_opp will return ERR_PTR(-EINVAL) then) so let's not crash in dev_name() in such case. Signed-off-by: Dmitry Torokhov Acked-by: Viresh Kumar Signed-off-by: Rafael J. Wysocki

PM / OPP: add some lockdep annotations

2014-12-18T00:42:49Z

Certain OPP APIs need to be called under RCU lock; let's add a few rcu_lockdep_assert() calls to warn about potential misuse. Signed-off-by: Dmitry Torokhov Acked-by: Viresh Kumar Signed-off-by: Rafael J. Wysocki

PM / OPP: do error handling at the bottom of dev_pm_opp_add_dynamic()

2014-12-10T21:18:34Z

This makes it less error prone and moves common resource deallocation at a single place. Signed-off-by: Viresh Kumar Signed-off-by: Rafael J. Wysocki

PM / OPP: handle allocation of device_opp in a separate routine

2014-12-10T21:18:34Z

Get the 'device_opp' allocation code into a separate routine to keep only the necessary part in dev_pm_opp_add_dynamic(). Also do s/sizeof(struct device_opp)/sizeof(*dev_opp) and remove the print message on kzalloc() failure as checkpatch warns for that. Signed-off-by: Viresh Kumar Signed-off-by: Rafael J. Wysocki